Feature/download sync #79

zerox80 · 2026-01-10T11:09:48Z

Download and Sync Feature

Summary

This PR adds the ability to download all files from the server and keep them synchronized locally. Users can now enable offline access for their entire account through the settings.

Changes

External Storage with Human-Readable Folder Names

Files are now stored in External storage with clear, readable folder names
Improved file organization for better user experience

Sync Option and Download All Files

Added new sync settings in the Security/Privacy section
Implemented DownloadEverythingWorker to handle bulk downloads
Implemented LocalFileSyncWorker to keep local files in sync with the server
Users can enable/disable the sync feature through settings

Worker Improvements

Fixed DownloadEverythingWorker to properly iterate through all folders and files
Improved error handling and progress reporting
Added proper recursive folder traversal

Localization

Changed German storage permission dialog text to English for consistency

Testing

Tested download of multiple files and folders
Verified sync worker runs correctly in the background
Confirmed files are stored in the correct external storage location

Related Issues

#24

samolego · 2026-01-11T09:00:36Z

This is a killer feature!
Question: what happens on file conflicts, e.g. if file is edited on web and on the device? How is synchronization handled?

Also, how does background sync work in regards of battery management in Android?

zerox80 · 2026-01-12T12:34:22Z

This is a killer feature! Question: what happens on file conflicts, e.g. if file is edited on web and on the device? How is synchronization handled?

Also, how does background sync work in regards of battery management in Android?

When a file changes both locally and remotely, automatically upload
the local version instead of requiring manual conflict resolution.
This provides a seamless auto-sync experience (last write wins).

https://github.com/zerox80/android/releases

samolego · 2026-01-12T15:13:09Z

When a file changes both locally and remotely, automatically upload
the local version instead of requiring manual conflict resolution.
This provides a seamless auto-sync experience (last write wins).

I don't think that's the best way to handle this. Desktop version pulls the file on conflict and names it _conflicted_copy or sth. similar.

I think we shouldn't be overwriting remote work, at least not without user confirmation.

samolego · 2026-01-11T08:55:05Z

opencloudApp/src/main/java/eu/opencloud/android/ui/activity/FileDisplayActivity.kt

+            if (!android.os.Environment.isExternalStorageManager()) {
+                val builder = AlertDialog.Builder(this)
+                builder.setTitle(getString(R.string.app_name))
+                builder.setMessage("To save offline files, the app needs access to all files.")


This strings should probably be translated

Yes, can do micro patch later

lets have focus on implementing the sync stuff perfectly, translation etc can be done later

samolego · 2026-01-11T08:56:03Z

opencloudApp/src/main/res/values/setup.xml

    <string name="db_file" formatted="false">opencloud.db</string>
    <string name="db_name" formatted="false">OpenCloud</string>
-    <string name="data_folder" formatted="false">opencloud</string>
+    <string name="data_folder" formatted="false">OpenCloud</string>


Is this necesarry?

looks better

zerox80 · 2026-01-12T15:20:59Z

When a file changes both locally and remotely, automatically upload
the local version instead of requiring manual conflict resolution.
This provides a seamless auto-sync experience (last write wins).

I don't think that's the best way to handle this. Desktop version pulls the file on conflict and names it _conflicted_copy or sth. similar.

I think we shouldn't be overwriting remote work, at least not without user confirmation.

But whats issue with last write win strategy? The manual user interaction is really bad UX, the Sync before that sync rework worked, but showed conflict. Its just very very unlikely that it will become an issue. The overwrite happens only if i change the file and save it. I think UX should imo have more priority, cuz thats a ~1% chance that it causes issues

zerox80 · 2026-01-12T15:23:00Z

When a file changes both locally and remotely, automatically upload
the local version instead of requiring manual conflict resolution.
This provides a seamless auto-sync experience (last write wins).

I don't think that's the best way to handle this. Desktop version pulls the file on conflict and names it _conflicted_copy or sth. similar.
I think we shouldn't be overwriting remote work, at least not without user confirmation.

But whats issue with last write win strategy? The manual user interaction is really bad UX, the Sync before that sync rework worked, but showed conflict. Its just very very unlikely that it will become an issue. The overwrite happens only if i change the file and save it. I think UX should imo have more priority, cuz thats a ~1% chance that it causes issues

So should we just add the conflict stuff again with a easy option "last write win" ? how should it be solved without causing a really really bad UX?

zerox80 · 2026-01-12T15:27:48Z

This is a killer feature! Question: what happens on file conflicts, e.g. if file is edited on web and on the device? How is synchronization handled?

Also, how does background sync work in regards of battery management in Android?

Have to test it, but i didn't have both open at same time. I only tested editing something, closing on web, editing 2 seconds later on Android. I planned to test that scenario today

zerox80 · 2026-01-12T15:37:24Z

@samolego
You're right that data safety should be prioritized. I'll implement a conflicted copy approach similar to the desktop version:

When both local and remote have changed, download the remote version AND keep the local file renamed as filename_conflicted_copy_.ext
This ensures no data loss while still avoiding manual intervention
The user can then compare and decide which version to keep

zerox80 · 2026-01-12T16:38:38Z

Please test it, and give feedback.
Theres option now with always last write wins (default: Off)

edit: Conflict files are in the OpenCloud Folder, not on Server

zerox80 · 2026-01-13T10:12:46Z

https://github.com/zerox80/android/releases/tag/2.0.11

This commit consolidates several improvements to the download and synchronization flow: - Implemented human-readable folder names on external storage for better accessibility. - Added 'Download all files' and 'Auto-Sync' capabilities. - Enhanced conflict resolution: - Automatically create local conflicted copies and download remote versions when both are modified (matching desktop behavior). - Added a security setting to toggle between 'Prefer local version' and 'Conflicted copy' strategies. - Improved conflict detection in both sync and direct upload paths. - Updated user avatars to use Graph API endpoints. - UI/UX improvements: - Translated storage permission dialogs to English for consistency. - Automated folder refresh after conflict resolution. - Technical debt and stability: - Fixed DownloadEverythingWorker logic. - Fixed ScopedStorageProviderTest by properly mocking Environment and updating expectations for non-URI-encoded paths.

…nizeFileUseCase

zerox80 force-pushed the feature/download-sync branch from 187f570 to 0f69672 Compare January 10, 2026 11:13

samolego suggested changes Jan 12, 2026

View reviewed changes

zerox80 force-pushed the feature/download-sync branch 2 times, most recently from 569314c to c55b72f Compare January 20, 2026 07:34

zerox80 force-pushed the feature/download-sync branch from c55b72f to 644300d Compare January 20, 2026 07:36

zerox80 added 2 commits January 20, 2026 08:52

fix: Optimize local sync performance and improve stability in Synchro…

abe086a

…nizeFileUseCase

Fix Detekt issues in download-sync feature

9a6d876

Feature/download sync #79

Are you sure you want to change the base?

Feature/download sync #79

Uh oh!

Conversation

zerox80 commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Download and Sync Feature

Summary

Changes

External Storage with Human-Readable Folder Names

Sync Option and Download All Files

Worker Improvements

Localization

Testing

Related Issues

Uh oh!

samolego commented Jan 11, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

samolego commented Jan 12, 2026

Uh oh!

samolego Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

zerox80 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

zerox80 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

samolego Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

zerox80 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zerox80 commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zerox80 commented Jan 10, 2026 •

edited

Loading

zerox80 commented Jan 12, 2026 •

edited

Loading